Empty email from contact form ?!

ingenting · May 31, 2013, 11:31am

fretburner:

The code seems OK… although I’d put a check around the PHP code so that it only runs once the form has been submitted, not when you first load the page:
if ($_SERVER['REQUEST_METHOD'] === 'POST') {
    // your emailing code here
}
As far as validating the email goes, as a start you could use a simple regex pattern - here’s an example function which will return true for valid addresses:
function valid_email($email) {
    regex = "/^[\\S]+@[\\S]+\\.[\\S]+$/"
    return (bool) preg_match($regex, (string) $email);
}
This is just a basic check, it won’t screen out all invalid addresses, but it gets you about 90% of the way there.

<?php
if ($_SERVER['REQUEST_METHOD'] === 'POST') {
	
	$email_to = "mail@email.com";
	$name = $_POST["name"];
	$email = $_POST["email"];
	$url = $_POST["url"];
	$message = $_POST["message"];
	$text = "User's Name: $name\
" .
    "User's Email: $email\
" .
    "User's TLF: $url\
" .
    "User's Message:\
\
" .
    "$message";
	$headers = "MIME-Version: 1.0" . "\\r\
"; 
	$headers .= "Content-type:text/html; charset=utf-8" . "\\r\
"; 
	$headers .= "FROM: <$email>" . "\\r\
";
	mail($email_to, "Message", $text, $headers);
} 
?>

Above is okay ?

Sorry not sure how to use/place it:

function valid_email($email) {
    regex = "/^[\\S]+@[\\S]+\\.[\\S]+$/"
    return (bool) preg_match($regex, (string) $email);
}

fretburner · May 31, 2013, 11:43am

You could do something like this:


function valid_email($email) {
    $regex = "/^[\\S]+@[\\S]+\\.[\\S]+$/"
    return (bool) preg_match($regex, (string) $email);
}

if ($_SERVER['REQUEST_METHOD'] === 'POST') {
    $email_to = "mail@email.com";
    $name = $_POST["name"];
    $email = $_POST["email"];
    $url = $_POST["url"];
    $message = $_POST["message"];

    // Check for valid form data
    if (!empty($email) AND valid_email($email) AND !empty($name) AND !empty($message)) {
         $text = "User's Name: $name\
" .
        "User's Email: $email\
" .
        "User's TLF: $url\
" .
        "User's Message:\
\
" .
        "$message";
        $headers = "MIME-Version: 1.0" . "\\r\
";
        $headers .= "Content-type:text/html; charset=utf-8" . "\\r\
";
        $headers .= "FROM: <$email>" . "\\r\
";
        mail($email_to, "Message", $text, $headers);
    }
}

ingenting · May 31, 2013, 12:29pm

fretburner:

You could do something like this:


function valid_email($email) { 
    $regex = "/^[\\S]+@[\\S]+\\.[\\S]+$/" 
    return (bool) preg_match($regex, (string) $email); 
} 

if ($_SERVER['REQUEST_METHOD'] === 'POST') {      
    $email_to = "mail@email.com"; 
    $name = $_POST["name"]; 
    $email = $_POST["email"]; 
    $url = $_POST["url"]; 
    $message = $_POST["message"];

    // Check for valid form data
    if (!empty($email) AND valid_email($email) AND !empty($name) AND !empty($message)) {
         $text = "User's Name: $name\
" . 
        "User's Email: $email\
" . 
        "User's TLF: $url\
" . 
        "User's Message:\
\
" . 
        "$message"; 
        $headers = "MIME-Version: 1.0" . "\\r\
";  
        $headers .= "Content-type:text/html; charset=utf-8" . "\\r\
";  
        $headers .= "FROM: <$email>" . "\\r\
"; 
        mail($email_to, "Message", $text, $headers); 
    }  
}

I have just copy/pasted above code
I get an error on this line :

return (bool) preg_match($regex, (string) $email);

fretburner · May 31, 2013, 12:30pm

Sorry, looks like I missed a semicolon off the end of this line $regex = "/^[\\S]+@[\\S]+\\.[\\S]+$/"

ingenting · May 31, 2013, 12:47pm

Great that helped.
Thanks alot for all your help, cant wait to see if this also makes the empty emails disappear.
Thanks again

captainccs · May 31, 2013, 12:52pm

No need to wait, try sending an empty email yourself.

ingenting · May 31, 2013, 1:11pm

You are right. I have tested it and it works. Thanks again