PHP Email Form Problems

PHP
1

Hi everyone,

I am trying to create a new PHP form email script. It should contain email validation functions that then 1. send the user to a page that lets them know there is an error with their email, and to please fill it out again. 2. If the email is blank or does not conform to the format, the email shouldn’t be sent.

There is one major problem with the script below: even though the script redirects the user to the page telling them there is a problem with the form, the email still sends.

I would like the email to NOT send, but instead only redirect the user to that page telling them they need to fill out the form again.

What’s wrong with the script that causes it to do this?


<?php
$name = $_POST['name'];
$email = $_POST['email'];
$phone = $_POST['phone'];
$comments = $_POST['comments'];

if( $name == true )
{
$sender = $email;
$receiver = "someemail@somewebsite.com";
$client_ip = $_SERVER['REMOTE_ADDR'];
$email_body = "Name: $name \
\
Email: $email \
\
Phone: $phone \
\
Comments: \
\
$comments \
\
IP: $client_ip \
\
Contact Sent from http://somewebsite.com/";
$newmessage = "Hi $name, \
\
Thank you for your inquiry. We will be in touch with you as quickly as possible. \
\
Please let us know if you have any further questions. Thank you.\
\
Phone: (800) 555-5555 \
Website:http://www.somewebsite.com/ \
\
Your inquiry has been copied below. \
\
 --------------------- \
\
Name: $name \
Email: $email \
\
Phone: $phone \
\
Case Information: \
\
$comments \
\
IP: $client_ip";
header( 'Location: http://somewebsite.com/contact-form-thank-you.html' ) ;
$extra = "From: $sender\\r\
" . "Reply-To: $sender \\r\
" . "X-Mailer: PHP/" . phpversion();
$extra2 = "From: $receiver\\r\
" . "Reply-To: $receiver \\r\
";

function check_email_address($email) {
// check that there's one @ symbol, and that the lengths are right
if (!preg_match("/^[^@]{1,64}@[^@]{1,255}$/", $email)) {
// Email invalid because wrong number of characters in one section, or wrong number of @ symbols.
return false;
}
// Split it into sections to make life easier
$email_array = explode("@", $email);
$local_array = explode(".", $email_array[0]);
for ($i = 0; $i < sizeof($local_array); $i++) {
if (!preg_match("/^(([A-Za-z0-9!#$%&'*+\\/=?^_`{|}~-][A-Za-z0-9!#$%&'*+\\/=?^_`{|}~\\.-]{0,63})|(\\"[^(\\\\|\\")]{0,62}\\"))$/", $local_array[$i])) {
return false;
}
}
if (!preg_match("/^\\[?[0-9\\.]+\\]?$/", $email_array[1])) { // Check if domain is IP. If not, it should be valid domain name
$domain_array = explode(".", $email_array[1]);
if (sizeof($domain_array) < 2) {
return false; // Not enough parts to domain
}
for ($i = 0; $i < sizeof($domain_array); $i++) {
if (!preg_match("/^(([A-Za-z0-9][A-Za-z0-9-]{0,61}[A-Za-z0-9])|([A-Za-z0-9]+))$/", $domain_array[$i])) {
return false;
}
}
}

return true;
}

if( mail( $receiver, "Somewebsite.com Inquiry", $email_body, $extra ) && mail( $sender, "Somewebsite.com Site Inquiry Has Been Received", $newmessage, $extra2 ) )

{
echo header("Location: contact-form-thank-you.html");
}
else
{
echo header("Location: contact-form-decline.html");
}
}
?>
2

You are not actually calling the check_email_address function anywhere!
There are some comments in the code below too.

Also try and indent code with either 4 spaces or TAB, it makes it easier to read, follow and track { }'s

<?php
/*
* Functions outside of the if() block
**/
function check_email_address($email) {
// check that there's one @ symbol, and that the lengths are right
    if (!preg_match("/^[^@]{1,64}@[^@]{1,255}$/", $email)) {    
// Email invalid because wrong number of characters in one section, or wrong number of @ symbols.
        return false;
    }
// Split it into sections to make life easier
    $email_array = explode("@", $email);
    $local_array = explode(".", $email_array[0]);


    for ($i = 0; $i < sizeof($local_array); $i++) {
        if (!preg_match("/^(([A-Za-z0-9!#$%&'*+\\/=?^_`{|}~-][A-Za-z0-9!#$%&'*+\\/=?^_`{|}~\\.-]{0,63})|(\\"[^(\\\\|\\")]{0,62}\\"))$/", $local_array[$i])) {
            return false;
        }
    }
    if (!preg_match("/^\\[?[0-9\\.]+\\]?$/", $email_array[1])) { // Check if domain is IP. If not, it should be valid domain name
        $domain_array = explode(".", $email_array[1]);
            if (sizeof($domain_array) < 2) {
                return false; // Not enough parts to domain
            }
        for ($i = 0; $i < sizeof($domain_array); $i++) {
            if (!preg_match("/^(([A-Za-z0-9][A-Za-z0-9-]{0,61}[A-Za-z0-9])|([A-Za-z0-9]+))$/", $domain_array[$i])) {
                return false;
            }
        }
    }


    return true;
}








$name = $_POST['name'];
$email = $_POST['email'];
$phone = $_POST['phone'];
$comments = $_POST['comments'];


if( $name == true ) // consider using isset() or check the length of $name variable.
{
    $sender = $email;
    $receiver = "someemail@somewebsite.com";
    $client_ip = $_SERVER['REMOTE_ADDR'];
    $email_body = "Name: $name \
\
Email: $email \
\
Phone: $phone \
\
Comments: \
\
$comments \
\
IP: $client_ip \
\
Contact Sent from http://somewebsite.com/";
    $newmessage = "Hi $name, \
\
Thank you for your inquiry. We will be in touch with you as quickly as possible. \
\
Please let us know if you have any further questions. Thank     you.\
\
Phone: (800) 555-5555 \
Website:http://www.somewebsite.com/ \
\
Your inquiry has been copied below. \
\
 --------------------- \
\
Name: $name \
Email: $email \
    \
Phone: $phone \
\
Case Information: \
\
$comments \
\
IP: $client_ip";
    
    header( 'Location: http://somewebsite.com/contact-form-thank-you.html' ) ;
    $extra = "From: $sender\\r\
" . "Reply-To: $sender \\r\
" . "X-Mailer: PHP/" . phpversion();
    $extra2 = "From: $receiver\\r\
" . "Reply-To: $receiver \\r\
";


    /*
    * Now you check if the email address is valid or not 
    */
    if(check_email_address($email) == true) {
        if( mail( $receiver, "Somewebsite.com Inquiry", $email_body, $extra ) && mail( $sender, "Somewebsite.com Site Inquiry Has Been Received", $newmessage, $extra2 ) )
        {
            echo header("Location: contact-form-thank-you.html");
        }
        else
        {
            echo header("Location: contact-form-decline.html");
        }
    } else {
        // do soemthing with it if it fails.
    }
}
?>
3

AWESOMENESS!! Thank you so much Mike. I’ve been buried pretty deep into this project and it’s nice to have a second pair of eyes.

Muchas gracias sir.

4

De nada amigo :slight_smile: