Update form with image

is possible to do something like
if if (mysql_num_rows($result) == 1) {
delete photo
}
if if (mysql_num_rows($result) == 0 ) {
insert photo
update album blabla
}
for an update form??? cz i am worried is gona keep looping evrytime0

Its working THANK YOU VERY MUCH FOR ALL THE HELP THANK YOU BIG THANK YOU

ok so after that if no errors i inserted the script that unlink the image from the folder but is giving me error is on the wrong place again??
Delete photo failed. You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ‘’ at line 5

<?php
define('ROOT_DIR', './');
define('THIS_SCRIPT', 'news');
define('PROPER', TRUE);
define("GALLERY_IMG_DIR", "./images/");
/**
* include common files
*/
include_once(ROOT_DIR. 'includes/common.inc.php');


 $id = $_POST['id']; 
    $name = $_POST['name'];
    $location = $_POST['location'];
    $date_of_birth = $_POST['date_of_birth'];
    $car_number = $_POST['car_number'];
    $favourite_track = $_POST['favourite_track'];
    $least_favourite_track = $_POST['least_favourite_track'];
    $achievements = $_POST['achievements'];
    $sponsors = $_POST['sponsors'];    
    $email = $_POST['email'];    
    $newname  = $_FILES['image'];
    
$query = "UPDATE driversnew SET name = '$name', location = '$location', date_of_birth='$date_of_birth', car_number='$car_number', favourite_track='$favourite_track', least_favourite_track='$least_favourite_track', achievements='$achievements', sponsors='$sponsors', email='$email'";


if($_FILES['image'] ['error'] === 0){

      // remove the image and the thumbnail from the server
      $sql = "SELECT id, image

           FROM drivernew

           WHERE id = {$_GET['image']}";

   $result = mysql_query($sql)

             or die('Delete photo failed. ' . mysql_error());

   if (mysql_num_rows($result) == 1) {

      $row = mysql_fetch_assoc($result);
      
define("GALLERY_IMG_DIR", "./images/");

      // remove the image and the thumbnail from the server
      unlink(GALLERY_IMG_DIR . $row['image']);

      unlink(GALLERY_IMG_DIR . 'thumbs/' . $row['image']);
   
//define a maxim size for the uploaded images
define ("MAX_SIZE","100");
// define the width and height for the thumbnail
// note that theese dimmensions are considered the maximum dimmension and are not fixed,
// because we have to keep the image ratio intact or it will be deformed
define ("WIDTH","150");
define ("HEIGHT","100");

// this is the function that will create the thumbnail image from the uploaded image
// the resize will be done considering the width and height defined, but without deforming the image
function make_thumb($img_name,$filename,$new_w,$new_h)
{
//get image extension.
$ext=getExtension($img_name);
//creates the new image using the appropriate function from gd library
if(!strcmp("jpg",$ext) || !strcmp("jpeg",$ext))
$src_img=imagecreatefromjpeg($img_name);

if(!strcmp("png",$ext))
$src_img=imagecreatefrompng($img_name);

//gets the dimmensions of the image
$old_x=imageSX($src_img);
$old_y=imageSY($src_img);

// next we will calculate the new dimmensions for the thumbnail image
// the next steps will be taken:
// 1. calculate the ratio by dividing the old dimmensions with the new ones
// 2. if the ratio for the width is higher, the width will remain the one define in WIDTH variable
// and the height will be calculated so the image ratio will not change
// 3. otherwise we will use the height ratio for the image
// as a result, only one of the dimmensions will be from the fixed ones
$ratio1=$old_x/$new_w;
$ratio2=$old_y/$new_h;
if($ratio1>$ratio2) {
$thumb_w=$new_w;
$thumb_h=$old_y/$ratio1;
}
else {
$thumb_h=$new_h;
$thumb_w=$old_x/$ratio2;
}

// we create a new image with the new dimmensions
$dst_img=ImageCreateTrueColor($thumb_w,$thumb_h);

// resize the big image to the new created one
imagecopyresampled($dst_img,$src_img,0,0,0,0,$thumb_w,$thumb_h,$old_x,$old_y);

// output the created image to the file. Now we will have the thumbnail into the file named by $filename
if(!strcmp("png",$ext))
imagepng($dst_img,$filename);
else
imagejpeg($dst_img,$filename);

//destroys source and destination images.
imagedestroy($dst_img);
imagedestroy($src_img);
}

// This function reads the extension of the file.
// It is used to determine if the file is an image by checking the extension.
function getExtension($str) {
$i = strrpos($str,".");
if (!$i) { return ""; }
$l = strlen($str) - $i;
$ext = substr($str,$i+1,$l);
return $ext;
}

// This variable is used as a flag. The value is initialized with 0 (meaning no error found)
//and it will be changed to 1 if an errro occures. If the error occures the file will not be uploaded.
$errors=0;
// checks if the form has been submitted
if(isset($_POST['Submit']))
{
//reads the name of the file the user submitted for uploading
$image=$_FILES['image']['name'];
// if it is not empty
if ($image)
{
// get the original name of the file from the clients machine
$filename = stripslashes($_FILES['image']['name']);

// get the extension of the file in a lower case format
$extension = getExtension($filename);
$extension = strtolower($extension);
// if it is not a known extension, we will suppose it is an error, print an error message
//and will not upload the file, otherwise we continue
if (($extension != "jpg") && ($extension != "jpeg") && ($extension != "png"))
{
echo '<h1>Unknown extension!</h1>';
$errors=1;
}
else
{
// get the size of the image in bytes
// $_FILES[\\'image\\'][\\'tmp_name\\'] is the temporary filename of the file in which the uploaded file was stored on the server
$size=getimagesize($_FILES['image']['tmp_name']);
$sizekb=filesize($_FILES['image']['tmp_name']);

//compare the size with the maxim size we defined anuploadd print error if bigger
if ($sizekb > MAX_SIZE*2024)
{
echo '<h1>You have exceeded the size limit!</h1>';
$errors=1;
}

//we will give an unique name, for example the time in unix time format
$image_name=time().'.'.$extension;
//the new name will be containing the full path where will be stored (images folder)
$newname="images/".$image_name;
$copied = copy($_FILES['image']['tmp_name'], $newname);
//we verify if the image has been uploaded, and print error instead
if (!$copied)
{
echo '<h1>Copy unsuccessfull!</h1>';
$errors=1;
}
else
{
// the new thumbnail image will be placed in images/thumbs/ folder
$thumb_name='images/thumbs/'.$image_name;
// call the function that will create the thumbnail. The function will get as parameters
//the image name, the thumbnail name and the width and height desired for the thumbnail
$thumb=make_thumb($newname,$thumb_name,WIDTH,HEIGHT);
}} }}

//If no errors registred, print the success message and show the thumbnail image created

   
$query .= ", image='$image_name'";
echo "It worked";
echo "<h1>Thumbnail created Successfully!</h1>";
echo '<img src="'.$thumb_name.'">';
echo ''.$image_name.'';

}
}
echo "Update sucefull";
$query .= " WHERE id = '$id'"; 

mysql_query($query) or die(mysql_error()); 


?>

Hi good afternnon now can u explain me a lil more about that line

if($_FILES['error'] === 0){
   $query .= ", image='$image'";

what does it mean cz i knw the double equals sign but 3 what are u trying to what i thinking is if no files do something but whats the error means??

Sorry wasn’t expecting a reply that quick. One sec

You still have the lines

if(isset($_POST)

on your upload form. Change these as well.

Seems like it doesn’t like one of the values you’re putting into the database. Try adding them one at a time and see which one breaks it. Then have a look at that one to see why it is breaking. Does it contain slashes? Does it have quotes? Should it have quotes? etc.

ok i will do one by one and see what happens??

Okay and if you do

var_dump($row = mysql_fetch_assoc($result));

do you get and array with the data in from that query? You don’t have to show the results here if they’re sensitive.

it says
resource(12) of type (mysql result)

In the insert script you have used the variable $image_name for the name of the image whereas the update script uses the variable $_FILES[‘image_image’] which does not exist. You need to change this to the name of the file ($image_name should work again here).

The file - the only thing I can think of now is the file directory does not exist you are trying to write to or you do not have permission to write to this directory. Check the directory exists and the permissions for the directory. If you are using a relative path to the directory, try changing it to an absolute path for testing (this should be something like /var/www/yourdirectory/ if you are using Apache).

As for the database update, the variable:

$_FILES['image_image'];

does not exist. If you remove this from the query (including the field name) does the rest of the data update if you amend it? Actually where is the database connection script? Is that in your include at the top?

well doenst update the database and doenst upload the file into directory

Is that the only issue you are having now?

still doenst update the database

so why it doesnt update from the form??

it doent upload the new image why

Morning :smiley:

You just need to put an if statement to check for the $_FILES array and then adjust your UPDATE statement:

$query = "UPDATE driversnew SET name = '$name', location = '$location', date_of_birth='$date_of_birth', car_number='$car_number', favourite_track='$favourite_track', least_favourite_track='$least_favourite_track', achievements='$achievements', sponsors='$sponsors', email='$email'";

if($_FILES['error'] === 0){
   $query .= ", image='$image'";
}

$query .= " WHERE id = '$id'"; 

mysql_query($query) or die(mysql_error());

Thanks Anthony.

I only registered to comment on this post :stuck_out_tongue: but I think I may stick around a while and type a little more carefully next time.

on the upload part it grabs the original name of the file and changed to image_name well u used to when i used on the insert page but since i used on the update page doenst seem to work this is how the upload script looks like u’ll notice it grabs image and change the name to image_name

define ("MAX_SIZE","100");
// define the width and height for the thumbnail
// note that theese dimmensions are considered the maximum dimmension and are not fixed,
// because we have to keep the image ratio intact or it will be deformed
define ("WIDTH","150");
define ("HEIGHT","100");

// this is the function that will create the thumbnail image from the uploaded image
// the resize will be done considering the width and height defined, but without deforming the image
function make_thumb($img_name,$filename,$new_w,$new_h)
{
//get image extension.
$ext=getExtension($img_name);
//creates the new image using the appropriate function from gd library
if(!strcmp("jpg",$ext) || !strcmp("jpeg",$ext))
$src_img=imagecreatefromjpeg($img_name);

if(!strcmp("png",$ext))
$src_img=imagecreatefrompng($img_name);

//gets the dimmensions of the image
$old_x=imageSX($src_img);
$old_y=imageSY($src_img);

// next we will calculate the new dimmensions for the thumbnail image
// the next steps will be taken:
// 1. calculate the ratio by dividing the old dimmensions with the new ones
// 2. if the ratio for the width is higher, the width will remain the one define in WIDTH variable
// and the height will be calculated so the image ratio will not change
// 3. otherwise we will use the height ratio for the image
// as a result, only one of the dimmensions will be from the fixed ones
$ratio1=$old_x/$new_w;
$ratio2=$old_y/$new_h;
if($ratio1>$ratio2) {
$thumb_w=$new_w;
$thumb_h=$old_y/$ratio1;
}
else {
$thumb_h=$new_h;
$thumb_w=$old_x/$ratio2;
}

// we create a new image with the new dimmensions
$dst_img=ImageCreateTrueColor($thumb_w,$thumb_h);

// resize the big image to the new created one
imagecopyresampled($dst_img,$src_img,0,0,0,0,$thumb_w,$thumb_h,$old_x,$old_y);

// output the created image to the file. Now we will have the thumbnail into the file named by $filename
if(!strcmp("png",$ext))
imagepng($dst_img,$filename);
else
imagejpeg($dst_img,$filename);

//destroys source and destination images.
imagedestroy($dst_img);
imagedestroy($src_img);
}

// This function reads the extension of the file.
// It is used to determine if the file is an image by checking the extension.
function getExtension($str) {
$i = strrpos($str,".");
if (!$i) { return ""; }
$l = strlen($str) - $i;
$ext = substr($str,$i+1,$l);
return $ext;
}

// This variable is used as a flag. The value is initialized with 0 (meaning no error found)
//and it will be changed to 1 if an errro occures. If the error occures the file will not be uploaded.
$errors=0;
// checks if the form has been submitted
if(isset($_POST['Submit']))
{
//reads the name of the file the user submitted for uploading
$image=$_FILES['image']['name'];
// if it is not empty
if ($image)
{
// get the original name of the file from the clients machine
$filename = stripslashes($_FILES['image']['name']);

// get the extension of the file in a lower case format
$extension = getExtension($filename);
$extension = strtolower($extension);
// if it is not a known extension, we will suppose it is an error, print an error message
//and will not upload the file, otherwise we continue
if (($extension != "jpg") && ($extension != "jpeg") && ($extension != "png"))
{
echo '<h1>Unknown extension!</h1>';
$errors=1;
}
else
{
// get the size of the image in bytes
// $_FILES[\\'image\\'][\\'tmp_name\\'] is the temporary filename of the file in which the uploaded file was stored on the server
$size=getimagesize($_FILES['image']['tmp_name']);
$sizekb=filesize($_FILES['image']['tmp_name']);

//compare the size with the maxim size we defined and print error if bigger
if ($sizekb > MAX_SIZE*1024)
{
echo '<h1>You have exceeded the size limit!</h1>';
$errors=1;
}

//we will give an unique name, for example the time in unix time format
$image_name=time().'.'.$extension;
//the new name will be containing the full path where will be stored (images folder)
$newname="images/".$image_name;
$copied = copy($_FILES['image']['tmp_name'], $newname);
//we verify if the image has been uploaded, and print error instead
if (!$copied)
{
echo '<h1>Copy unsuccessfull!</h1>';
$errors=1;

}
else
{
// the new thumbnail image will be placed in images/thumbs/ folder
$thumb_name='images/thumbs/'.$image_name;
// call the function that will create the thumbnail. The function will get as parameters
//the image name, the thumbnail name and the width and height desired for the thumbnail
$thumb=make_thumb($newname,$thumb_name,WIDTH,HEIGHT);
}} }}